Commit 9583ec77 authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Greg Kroah-Hartman

s390/qdio: don't touch the dsci in tiqdio_add_input_queues()

commit ac6639cd3db607d386616487902b4cc1850a7be5 upstream.

Current code sets the dsci to 0x00000080. Which doesn't make any sense,
as the indicator area is located in the _left-most_ byte.

Worse: if the dsci is the _shared_ indicator, this potentially clears
the indication of activity for a _different_ device.
tiqdio_thinint_handler() will then have no reason to call that device's
IRQ handler, and the device ends up stalling.

Fixes: d0c9d4a8 ("[S390] qdio: set correct bit in dsci")
Cc: <>
Signed-off-by: default avatarJulian Wiedmann <>
Signed-off-by: default avatarVasily Gorbik <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent a25b1a8f
......@@ -83,7 +83,6 @@ void tiqdio_add_input_queues(struct qdio_irq *irq_ptr)
list_add_rcu(&irq_ptr->input_qs[0]->entry, &tiq_list);
xchg(irq_ptr->dsci, 1 << 7);
void tiqdio_remove_input_queues(struct qdio_irq *irq_ptr)
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment