Commit d4c72a41 authored by Xin Long's avatar Xin Long Committed by Greg Kroah-Hartman

sctp: only allow the asoc reset when the asoc outq is empty

[ Upstream commit 5c6144a0 ]

As it says in rfc6525#section5.1.4, before sending the request,

   C2:  The sender has either no outstanding TSNs or considers all
        outstanding TSNs abandoned.

Prior to this patch, it tried to consider all outstanding TSNs abandoned
by dropping all chunks in all outqs with sctp_outq_free (even including
sacked, retransmit and transmitted queues) when doing this reset, which
is too aggressive.

To make it work gently, this patch will only allow the asoc reset when
the sender has no outstanding TSNs by checking if unsent, transmitted
and retransmit are all empty with sctp_outq_is_empty before sending
and processing the request.

Fixes: 692787ce ("sctp: implement receiver-side procedures for the SSN/TSN Reset Request Parameter")
Signed-off-by: default avatarXin Long <>
Acked-by: default avatarMarcelo Ricardo Leitner <>
Signed-off-by: default avatarDavid S. Miller <>
Signed-off-by: default avatarSasha Levin <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 928066e6
......@@ -224,6 +224,9 @@ int sctp_send_reset_assoc(struct sctp_association *asoc)
if (asoc->strreset_outstanding)
if (!sctp_outq_is_empty(&asoc->outqueue))
return -EAGAIN;
chunk = sctp_make_strreset_tsnreq(asoc);
if (!chunk)
return -ENOMEM;
......@@ -544,6 +547,12 @@ struct sctp_chunk *sctp_process_strreset_tsnreq(
goto err;
if (!sctp_outq_is_empty(&asoc->outqueue)) {
goto err;
if (!(asoc->strreset_enable & SCTP_ENABLE_RESET_ASSOC_REQ))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment