Commit e09e2867 authored by Amey Telawane's avatar Amey Telawane Committed by Steven Rostedt (VMware)

tracing: Use strlcpy() instead of strcpy() in __trace_find_cmdline()

Strcpy is inherently not safe, and strlcpy() should be used instead.
__trace_find_cmdline() uses strcpy() because the comms saved must have a
terminating nul character, but it doesn't hurt to add the extra protection
of using strlcpy() instead of strcpy().

Link: default avatarAmey Telawane <>
[AmitP: Cherry-picked this commit from CodeAurora kernel/msm-3.10]
Signed-off-by: default avatarAmit Pundir <>
[ Updated change log and removed the "- 1" from len parameter ]
Signed-off-by: default avatarSteven Rostedt (VMware) <>
parent 4c174688
......@@ -1976,7 +1976,7 @@ static void __trace_find_cmdline(int pid, char comm[])
map = savedcmd->map_pid_to_cmdline[pid];
if (map != NO_CMDLINE_MAP)
strcpy(comm, get_saved_cmdlines(map));
strlcpy(comm, get_saved_cmdlines(map), TASK_COMM_LEN);
strcpy(comm, "<...>");
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment