1. 21 Jul, 2019 1 commit
  2. 15 Feb, 2019 1 commit
  3. 24 Aug, 2018 3 commits
  4. 26 Apr, 2018 1 commit
  5. 20 Dec, 2017 1 commit
  6. 02 Nov, 2017 1 commit
    • Greg Kroah-Hartman's avatar
      License cleanup: add SPDX GPL-2.0 license identifier to files with no license · b2441318
      Greg Kroah-Hartman authored
      Many source files in the tree are missing licensing information, which
      makes it harder for compliance tools to determine the correct license.
      
      By default all files without license information are under the default
      license of the kernel, which is GPL version 2.
      
      Update the files which contain no license information with the 'GPL-2.0'
      SPDX license identifier.  The SPDX identifier is a legally binding
      shorthand, which can be used instead of the full boiler plate text.
      
      This patch is based on work done by Thomas Gleixner and Kate Stewart and
      Philippe Ombredanne.
      
      How this work was done:
      
      Patches were generated and checked against linux-4.14-rc6 for a subset of
      the use cases:
       - file had no licensing information it it.
       - file was a */uapi/* one with no licensing information in it,
       - file was a */uapi/* one with existing licensing information,
      
      Further patches will be generated in subsequent months to fix up cases
      where non-standard license headers were used, and references to license
      had to be inferred by heuristics based on keywords.
      
      The analysis to determine which SPDX License Identifier to be applied to
      a file was done in a spreadsheet of side by side results from of the
      output of two independent scanners (ScanCode & Windriver) producing SPDX
      tag:value files created by Philippe Ombredanne.  Philippe prepared the
      base worksheet, and did an initial spot review of a few 1000 files.
      
      The 4.13 kernel was the starting point of the analysis with 60,537 files
      assessed.  Kate Stewart did a file by file comparison of the scanner
      results in the spreadsheet to determine which SPDX license identifier(s)
      to be applied to the file. She confirmed any determination that was not
      immediately clear with lawyers working with the Linux Foundation.
      
      Criteria used to select files for SPDX license identifier tagging was:
       - Files considered eligible had to be source code files.
       - Make and config files were included as candidates if they contained >5
         lines of source
       - File already had some variant of a license header in it (even if <5
         lines).
      
      All documentation files were explicitly excluded.
      
      The following heuristics were used to determine which SPDX license
      identifiers to apply.
      
       - when both scanners couldn't find any license traces, file was
         considered to have no license information in it, and the top level
         COPYING file license applied.
      
         For non */uapi/* files that summary was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0                                              11139
      
         and resulted in the first patch in this series.
      
         If that file was a */uapi/* path one, it was "GPL-2.0 WITH
         Linux-syscall-note" otherwise it was "GPL-2.0".  Results of that was:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|-------
         GPL-2.0 WITH Linux-syscall-note                        930
      
         and resulted in the second patch in this series.
      
       - if a file had some form of licensing information in it, and was one
         of the */uapi/* ones, it was denoted with the Linux-syscall-note if
         any GPL family license was found in the file or had no licensing in
         it (per prior point).  Results summary:
      
         SPDX license identifier                            # files
         ---------------------------------------------------|------
         GPL-2.0 WITH Linux-syscall-note                       270
         GPL-2.0+ WITH Linux-syscall-note                      169
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause)    21
         ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)    17
         LGPL-2.1+ WITH Linux-syscall-note                      15
         GPL-1.0+ WITH Linux-syscall-note                       14
         ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause)    5
         LGPL-2.0+ WITH Linux-syscall-note                       4
         LGPL-2.1 WITH Linux-syscall-note                        3
         ((GPL-2.0 WITH Linux-syscall-note) OR MIT)              3
         ((GPL-2.0 WITH Linux-syscall-note) AND MIT)             1
      
         and that resulted in the third patch in this series.
      
       - when the two scanners agreed on the detected license(s), that became
         the concluded license(s).
      
       - when there was disagreement between the two scanners (one detected a
         license but the other didn't, or they both detected different
         licenses) a manual inspection of the file occurred.
      
       - In most cases a manual inspection of the information in the file
         resulted in a clear resolution of the license that should apply (and
         which scanner probably needed to revisit its heuristics).
      
       - When it was not immediately clear, the license identifier was
         confirmed with lawyers working with the Linux Foundation.
      
       - If there was any question as to the appropriate license identifier,
         the file was flagged for further research and to be revisited later
         in time.
      
      In total, over 70 hours of logged manual review was done on the
      spreadsheet to determine the SPDX license identifiers to apply to the
      source files by Kate, Philippe, Thomas and, in some cases, confirmation
      by lawyers working with the Linux Foundation.
      
      Kate also obtained a third independent scan of the 4.13 code base from
      FOSSology, and compared selected files where the other two scanners
      disagreed against that SPDX file, to see if there was new insights.  The
      Windriver scanner is based on an older version of FOSSology in part, so
      they are related.
      
      Thomas did random spot checks in about 500 files from the spreadsheets
      for the uapi headers and agreed with SPDX license identifier in the
      files he inspected. For the non-uapi files Thomas did random spot checks
      in about 15000 files.
      
      In initial set of patches against 4.14-rc6, 3 files were found to have
      copy/paste license identifier errors, and have been fixed to reflect the
      correct identifier.
      
      Additionally Philippe spent 10 hours this week doing a detailed manual
      inspection and review of the 12,461 patched files from the initial patch
      version early this week with:
       - a full scancode scan run, collecting the matched texts, detected
         license ids and scores
       - reviewing anything where there was a license detected (about 500+
         files) to ensure that the applied SPDX license was correct
       - reviewing anything where there was no detection but the patch license
         was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
         SPDX license was correct
      
      This produced a worksheet with 20 files needing minor correction.  This
      worksheet was then exported into 3 different .csv files for the
      different types of files to be modified.
      
      These .csv files were then reviewed by Greg.  Thomas wrote a script to
      parse the csv files and add the proper SPDX tag to the file, in the
      format that the file expected.  This script was further refined by Greg
      based on the output to detect more types of files automatically and to
      distinguish between header and source .c files (which need different
      comment types.)  Finally Greg ran the script using the .csv files to
      generate the patches.
      Reviewed-by: 's avatarKate Stewart <kstewart@linuxfoundation.org>
      Reviewed-by: 's avatarPhilippe Ombredanne <pombredanne@nexb.com>
      Reviewed-by: 's avatarThomas Gleixner <tglx@linutronix.de>
      Signed-off-by: 's avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      b2441318
  7. 28 Oct, 2017 1 commit
  8. 20 Oct, 2017 1 commit
  9. 17 Oct, 2017 1 commit
    • Steven Rostedt (VMware)'s avatar
      tracing/samples: Fix creation and deletion of simple_thread_fn creation · 6575257c
      Steven Rostedt (VMware) authored
      Commit 7496946a ("tracing: Add samples of DECLARE_EVENT_CLASS() and
      DEFINE_EVENT()") added template examples for all the events. It created a
      DEFINE_EVENT_FN() example which reused the foo_bar_reg and foo_bar_unreg
      functions.
      
      Enabling both the TRACE_EVENT_FN() and DEFINE_EVENT_FN() example trace
      events caused the foo_bar_reg to be called twice, creating the test thread
      twice. The foo_bar_unreg would remove it only once, even if it was called
      multiple times, leaving a thread existing when the module is unloaded,
      causing an oops.
      
      Add a ref count and allow foo_bar_reg() and foo_bar_unreg() be called by
      multiple trace events.
      
      Cc: stable@vger.kernel.org
      Fixes: 7496946a ("tracing: Add samples of DECLARE_EVENT_CLASS() and DEFINE_EVENT()")
      Signed-off-by: 's avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
      6575257c
  10. 01 Sep, 2017 6 commits
  11. 31 Aug, 2017 1 commit
  12. 29 Aug, 2017 2 commits
    • Jesper Dangaard Brouer's avatar
      samples/bpf: xdp_monitor tool based on tracepoints · 3ffab546
      Jesper Dangaard Brouer authored
      This tool xdp_monitor demonstrate how to use the different xdp_redirect
      tracepoints xdp_redirect{,_map}{,_err} from a BPF program.
      
      The default mode is to only monitor the error counters, to avoid
      affecting the per packet performance. Tracepoints comes with a base
      overhead of 25 nanosec for an attached bpf_prog, and 48 nanosec for
      using a full perf record (with non-matching filter).  Thus, default
      loading the --stats mode could affect the maximum performance.
      
      This version of the tool is very simple and count all types of errors
      as one.  It will be natural to extend this later with the different
      types of errors that can occur, which should help users quickly
      identify common mistakes.
      
      Because the TP_STRUCT was kept in sync all the tracepoints loads the
      same BPF code.  It would also be natural to extend the map version to
      demonstrate how the map information could be used.
      Signed-off-by: 's avatarJesper Dangaard Brouer <brouer@redhat.com>
      Acked-by: 's avatarAlexei Starovoitov <ast@kernel.org>
      Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
      3ffab546
    • Jesper Dangaard Brouer's avatar
      samples/bpf: xdp_redirect load XDP dummy prog on TX device · 306da4e6
      Jesper Dangaard Brouer authored
      For supporting XDP_REDIRECT, a device driver must (obviously)
      implement the "TX" function ndo_xdp_xmit().  An additional requirement
      is you cannot TX out a device, unless it also have a xdp bpf program
      attached. This dependency is caused by the driver code need to setup
      XDP resources before it can ndo_xdp_xmit.
      
      Update bpf samples xdp_redirect and xdp_redirect_map to automatically
      attach a dummy XDP program to the configured ifindex_out device.  Use
      the XDP flag XDP_FLAGS_UPDATE_IF_NOEXIST on the dummy load, to avoid
      overriding an existing XDP prog on the device.
      Signed-off-by: 's avatarJesper Dangaard Brouer <brouer@redhat.com>
      Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
      306da4e6
  13. 28 Aug, 2017 2 commits
  14. 20 Aug, 2017 2 commits
  15. 17 Aug, 2017 1 commit
  16. 16 Aug, 2017 1 commit
    • John Fastabend's avatar
      bpf: sockmap sample program · 69e8cc13
      John Fastabend authored
      This program binds a program to a cgroup and then matches hard
      coded IP addresses and adds these to a sockmap.
      
      This will receive messages from the backend and send them to
      the client.
      
           client:X <---> frontend:10000 client:X <---> backend:10001
      
      To keep things simple this is only designed for 1:1 connections
      using hard coded values. A more complete example would allow many
      backends and clients.
      
      To run,
      
       # sockmap <cgroup2_dir>
      Signed-off-by: 's avatarJohn Fastabend <john.fastabend@gmail.com>
      Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
      69e8cc13
  17. 14 Aug, 2017 1 commit
  18. 07 Aug, 2017 1 commit
  19. 01 Aug, 2017 1 commit
  20. 17 Jul, 2017 3 commits
  21. 12 Jul, 2017 2 commits
  22. 05 Jul, 2017 1 commit
    • Lawrence Brakmo's avatar
      bpf: fix return in load_bpf_file · f856e469
      Lawrence Brakmo authored
      The function load_bpf_file ignores the return value of
      load_and_attach(), so even if load_and_attach() returns an error,
      load_bpf_file() will return 0.
      
      Now, load_bpf_file() can call load_and_attach() multiple times and some
      can succeed and some could fail. I think the correct behavor is to
      return error on the first failed load_and_attach().
      
      v2: Added missing SOB
      Signed-off-by: 's avatarLawrence Brakmo <brakmo@fb.com>
      Signed-off-by: 's avatarDavid S. Miller <davem@davemloft.net>
      f856e469
  23. 01 Jul, 2017 5 commits