• Prabhakar Lad's avatar
    media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS · b25db383
    Prabhakar Lad authored
    drop VPFE_CMD_S_CCDC_RAW_PARAMS ioctl from dm355/dm644x following reasons:
    
    - This ioctl was never in public api and was only defined in kernel header.
    - The function set_params constantly mixes up pointers and phys_addr_t
      numbers.
    - This is part of a 'VPFE_CMD_S_CCDC_RAW_PARAMS' ioctl command that is
      described as an 'experimental ioctl that will change in future kernels'.
    - The code to allocate the table never gets called after we copy_from_user
      the user input over the kernel settings, and then compare them
      for inequality.
    - We then go on to use an address provided by user space as both the
      __user pointer for input and pass it through phys_to_virt to come up
      with a kernel pointer to copy the data to. This looks like a trivially
      exploitable root hole.
    Signed-off-by: 's avatarLad, Prabhakar <prabhakar.csengg@gmail.com>
    Signed-off-by: 's avatarHans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: 's avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    b25db383
Name
Last commit
Last update
..
ccdc_types.h Loading commit data...
dm355_ccdc.h Loading commit data...
dm644x_ccdc.h Loading commit data...
isif.h Loading commit data...
vpbe.h Loading commit data...
vpbe_display.h Loading commit data...
vpbe_osd.h Loading commit data...
vpbe_types.h Loading commit data...
vpbe_venc.h Loading commit data...
vpfe_capture.h Loading commit data...
vpfe_types.h Loading commit data...
vpif_types.h Loading commit data...
vpss.h Loading commit data...