Skip to content
  • Huaitong Han's avatar
    kvm: x86: Fix vmwrite to SECONDARY_VM_EXEC_CONTROL · 45bdbcfd
    Huaitong Han authored
    vmx_cpuid_tries to update SECONDARY_VM_EXEC_CONTROL in the VMCS, but
    it will cause a vmwrite error on older CPUs because the code does not
    check for the presence of CPU_BASED_ACTIVATE_SECONDARY_CONTROLS.
    
    This will get rid of the following trace on e.g. Core2 6600:
    
    vmwrite error: reg 401e value 10 (err 12)
    Call Trace:
    [<ffffffff8116e2b9>] dump_stack+0x40/0x57
    [<ffffffffa020b88d>] vmx_cpuid_update+0x5d/0x150 [kvm_intel]
    [<ffffffffa01d8fdc>] kvm_vcpu_ioctl_set_cpuid2+0x4c/0x70 [kvm]
    [<ffffffffa01b8363>] kvm_arch_vcpu_ioctl+0x903/0xfa0 [kvm]
    
    Fixes: feda805f
    
    
    Cc: stable@vger.kernel.org
    Reported-by: default avatarZdenek Kaspar <zkaspar82@gmail.com>
    Signed-off-by: default avatarHuaitong Han <huaitong.han@intel.com>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    45bdbcfd