• Cameron Gutman's avatar
    Input: xpad - fix oops when attaching an unknown Xbox One gamepad · 526410bc
    Cameron Gutman authored
    commit c7f14293 upstream.
    Xbox One controllers have multiple interfaces which all have the
    same class, subclass, and protocol. One of the these interfaces
    has only a single endpoint. When Xpad attempts to bind to this
    interface, it causes an oops when trying initialize the output URB
    by trying to access the second endpoint's descriptor.
    This situation was avoided for known Xbox One devices by checking
    the XTYPE constant associated with the VID and PID tuple. However,
    this breaks when new or previously unknown Xbox One controllers
    are attached to the system.
    This change addresses the problem by deriving the XTYPE for Xbox
    One controllers based on the interface protocol before checking
    the interface number.
    Fixes: 1a48ff81 ("Input: xpad - add support for Xbox One controllers")
    Signed-off-by: default avatarCameron Gutman <aicommander@gmail.com>
    Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
xpad.c 41.4 KB