Skip to content
  • Paul Jackson's avatar
    hotplug cpu: move tasks in empty cpusets to parent various other fixes · c8d9c90c
    Paul Jackson authored
    
    
    Various minor formatting and comment tweaks to Cliff Wickman's
    [PATCH_3_of_3]_cpusets__update_cpumask_revision.patch
    
    I had had "iff", meaning "if and only if" in a comment.  However, except for
    ancient mathematicians, the abbreviation "iff" was a tad too cryptic.  Cliff
    changed it to "if", presumably figuring that the "iff" was a typo.  However,
    it was the "only if" half of the conjunction that was most interesting.
    Reword to emphasis the "only if" aspect.
    
    The locking comment for remove_tasks_in_empty_cpuset() was wrong; it said
    callback_mutex had to be held on entry.  The opposite is true.
    
    Several mentions of attach_task() in comments needed to be
    changed to cgroup_attach_task().
    
    A comment about notify_on_release was no longer relevant,
    as the line of code it had commented, namely:
    	set_bit(CS_RELEASED_RESOURCE, &parent->flags);
    is no longer present in that place in the cpuset.c code.
    
    Similarly a comment about notify_on_release before the
    scan_for_empty_cpusets() routine was no longer relevant.
    
    Removed extra parentheses and unnecessary return statement.
    
    Renamed attach_task() to cpuset_attach() in various comments.
    
    Removed comment about not needing memory migration, as it seems the migration
    is done anyway, via the cpuset_attach() callback from cgroup_attach_task().
    
    Signed-off-by: default avatarPaul Jackson <pj@sgi.com>
    Acked-by: default avatarCliff Wickman <cpw@sgi.com>
    Cc: David Rientjes <rientjes@google.com>
    Cc: Paul Menage <menage@google.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    c8d9c90c