Skip to content
  • J. Bruce Fields's avatar
    exportfs: fix quadratic behavior in filehandle lookup · f27c9298
    J. Bruce Fields authored
    
    
    Suppose we're given the filehandle for a directory whose closest
    ancestor in the dcache is its Nth ancestor.
    
    The main loop in reconnect_path searches for an IS_ROOT ancestor of
    target_dir, reconnects that ancestor to its parent, then recommences the
    search for an IS_ROOT ancestor from target_dir.
    
    This behavior is quadratic in N.  And there's really no need to restart
    the search from target_dir each time: once a directory has been looked
    up, it won't become IS_ROOT again.  So instead of starting from
    target_dir each time, we can continue where we left off.
    
    This simplifies the code and improves performance on very deep directory
    heirachies.  (I can't think of any reason anyone should need heirarchies
    a hundred or more deep, but the performance improvement may be valuable
    if only to limit damage in case of abuse.)
    
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    f27c9298