Commit 06f1631a authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds

signals: send_sigio: use do_send_sig_info() to avoid check_kill_permission()

group_send_sig_info()->check_kill_permission() assumes that current is the
sender and uses current_cred().

This is not true in send_sigio_to_task() case.  From the security pov the
sender is not current, but the task which did fcntl(F_SETOWN), that is why
we have sigio_perm() which uses the right creds to check.

Fortunately, send_sigio() always sends either SEND_SIG_PRIV or
SI_FROMKERNEL() signal, so check_kill_permission() does nothing.  But
still it would be tidier to avoid this bogus security check and save a
couple of cycles.
Signed-off-by: default avatarOleg Nesterov <>
Cc: Peter Zijlstra <>
Cc: stephane eranian <>
Cc: Ingo Molnar <>
Cc: Roland McGrath <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 4a30debf
......@@ -461,11 +461,11 @@ static void send_sigio_to_task(struct task_struct *p,
si.si_band = band_table[reason - POLL_IN];
si.si_fd = fd;
if (!group_send_sig_info(signum, &si, p))
if (!do_send_sig_info(signum, &si, p, true))
/* fall-through: fall back on the old plain SIGIO signal */
case 0:
group_send_sig_info(SIGIO, SEND_SIG_PRIV, p);
do_send_sig_info(SIGIO, SEND_SIG_PRIV, p, true);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment