Commit 08dd0381 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

usb: host: fix incorrect updating of offset

commit 1d5a3158 upstream.

The variable temp is incorrectly being updated, instead it should
be offset otherwise the loop just reads the same capability value
and loops forever.  Thanks to Alan Stern for pointing out the
correct fix to my original fix.  Fix also cleans up clang warning:

drivers/usb/host/ehci-dbg.c:840:4: warning: Value stored to 'temp'
is never read

Fixes: d49d4317 ("USB: misc ehci updates")
Signed-off-by: default avatarColin Ian King <>
Acked-by: default avatarAlan Stern <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 20c315eb
......@@ -837,7 +837,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
default: /* unknown */
temp = (cap >> 8) & 0xff;
offset = (cap >> 8) & 0xff;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment