Commit 5b54470d authored by Dan Carpenter's avatar Dan Carpenter Committed by Al Viro

fcntl: return -EFAULT if copy_to_user fails

copy_to_user() returns the number of bytes remaining, but we want to
return -EFAULT.
	ret = fcntl(fd, F_SETOWN_EX, NULL);
With the original code ret would be 8 here.

V2: Takuya Yoshikawa pointed out a similar issue in f_getown_ex()
Signed-off-by: default avatarDan Carpenter <>
Signed-off-by: default avatarAl Viro <>
parent 7d683a09
......@@ -274,7 +274,7 @@ static int f_setown_ex(struct file *filp, unsigned long arg)
ret = copy_from_user(&owner, owner_p, sizeof(owner));
if (ret)
return ret;
return -EFAULT;
switch (owner.type) {
......@@ -332,8 +332,11 @@ static int f_getown_ex(struct file *filp, unsigned long arg)
if (!ret)
if (!ret) {
ret = copy_to_user(owner_p, &owner, sizeof(owner));
if (ret)
ret = -EFAULT;
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment