Commit 60e377b5 authored by Alexandre Bounine's avatar Alexandre Bounine Committed by Linus Torvalds

rapidio/idt_gen2: fix locking warning

Fix lockdep warning during device probing: move sysfs initialization out
of code protected by a spin lock.

Link: http://lkml.kernel.org/r/1469125134-16523-10-git-send-email-alexandre.bounine@idt.comSigned-off-by: default avatarAlexandre Bounine <alexandre.bounine@idt.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Andre van Herk <andre.van.herk@prodrive-technologies.com>
Cc: Barry Wood <barry.wood@idt.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 06e1b249
...@@ -436,10 +436,11 @@ static int idtg2_probe(struct rio_dev *rdev, const struct rio_device_id *id) ...@@ -436,10 +436,11 @@ static int idtg2_probe(struct rio_dev *rdev, const struct rio_device_id *id)
RIO_STD_RTE_DEFAULT_PORT, IDT_NO_ROUTE); RIO_STD_RTE_DEFAULT_PORT, IDT_NO_ROUTE);
} }
spin_unlock(&rdev->rswitch->lock);
/* Create device-specific sysfs attributes */ /* Create device-specific sysfs attributes */
idtg2_sysfs(rdev, true); idtg2_sysfs(rdev, true);
spin_unlock(&rdev->rswitch->lock);
return 0; return 0;
} }
...@@ -452,11 +453,9 @@ static void idtg2_remove(struct rio_dev *rdev) ...@@ -452,11 +453,9 @@ static void idtg2_remove(struct rio_dev *rdev)
return; return;
} }
rdev->rswitch->ops = NULL; rdev->rswitch->ops = NULL;
spin_unlock(&rdev->rswitch->lock);
/* Remove device-specific sysfs attributes */ /* Remove device-specific sysfs attributes */
idtg2_sysfs(rdev, false); idtg2_sysfs(rdev, false);
spin_unlock(&rdev->rswitch->lock);
} }
static struct rio_device_id idtg2_id_table[] = { static struct rio_device_id idtg2_id_table[] = {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment