Commit c6f28489 authored by Lendacky, Thomas's avatar Lendacky, Thomas Committed by Greg Kroah-Hartman

amd-xgbe: Check xgbe_init() return code

[ Upstream commit 738f7f64 ]

The xgbe_init() routine returns a return code indicating success or
failure, but the return code is not checked. Add code to xgbe_init()
to issue a message when failures are seen and add code to check the
xgbe_init() return code.
Signed-off-by: default avatarTom Lendacky <>
Signed-off-by: default avatarDavid S. Miller <>
Signed-off-by: default avatarSasha Levin <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent e99d86d7
...@@ -2825,8 +2825,10 @@ static int xgbe_init(struct xgbe_prv_data *pdata) ...@@ -2825,8 +2825,10 @@ static int xgbe_init(struct xgbe_prv_data *pdata)
/* Flush Tx queues */ /* Flush Tx queues */
ret = xgbe_flush_tx_queues(pdata); ret = xgbe_flush_tx_queues(pdata);
if (ret) if (ret) {
netdev_err(pdata->netdev, "error flushing TX queues\n");
return ret; return ret;
/* /*
* Initialize DMA related features * Initialize DMA related features
...@@ -877,7 +877,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata) ...@@ -877,7 +877,9 @@ static int xgbe_start(struct xgbe_prv_data *pdata)
DBGPR("-->xgbe_start\n"); DBGPR("-->xgbe_start\n");
hw_if->init(pdata); ret = hw_if->init(pdata);
if (ret)
return ret;
ret = phy_if->phy_start(pdata); ret = phy_if->phy_start(pdata);
if (ret) if (ret)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment