Commit e6ac89fa authored by Jason Wessel's avatar Jason Wessel Committed by Michal Marek

kbuild: Correctly deal with make options which contain an "s"

When using remake, which is based on gnumake, if you invoke
an example build as shown below, the build will become silent
due to the top level make file incorrectly guessing that
the end user wants a silent build because an argument that
contained an "s" was used.  Here are two examples one with remake
and one with straight gnumake.

remake --no-extended-errors
make --warn-undefined-variables

Fix up the top level Makefile to use filter to parse the options
that mean silent instead of findstring catching other random
arguments containing an "s".
Signed-off-by: default avatarJason Wessel <>
CC: Michal Marek <>
CC: Andrew Morton <>
Signed-off-by: default avatarMichal Marek <>
parent 5f7efb4c
......@@ -312,7 +312,7 @@ endif
# If the user is running make -s (silent mode), suppress echoing of
# commands
ifneq ($(findstring s,$(MAKEFLAGS)),)
ifneq ($(filter s% -s%,$(MAKEFLAGS)),)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment