Commit e839b6a1 authored by Michal Hocko's avatar Michal Hocko Committed by Linus Torvalds

memcg, vmscan: do not attempt soft limit reclaim if it would not scan anything

mem_cgroup_should_soft_reclaim controls whether soft reclaim pass is
done and it always says yes currently.  Memcg iterators are clever to
skip nodes that are not soft reclaimable quite efficiently but
mem_cgroup_should_soft_reclaim can be more clever and do not start the
soft reclaim pass at all if it knows that nothing would be scanned

In order to do that, simply reuse mem_cgroup_soft_reclaim_eligible for
the target group of the reclaim and allow the pass only if the whole
subtree wouldn't be skipped.
Signed-off-by: default avatarMichal Hocko <>
Cc: Balbir Singh <>
Cc: Glauber Costa <>
Cc: Greg Thelen <>
Cc: Hugh Dickins <>
Cc: Johannes Weiner <>
Cc: KAMEZAWA Hiroyuki <>
Cc: KOSAKI Motohiro <>
Cc: Michel Lespinasse <>
Cc: Tejun Heo <>
Cc: Ying Han <>
Signed-off-by: default avatarAndrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 7d910c05
......@@ -1885,7 +1885,11 @@ enum mem_cgroup_filter_t
mem_cgroup_soft_reclaim_eligible(struct mem_cgroup *memcg,
struct mem_cgroup *root)
struct mem_cgroup *parent = memcg;
struct mem_cgroup *parent;
if (!memcg)
memcg = root_mem_cgroup;
parent = memcg;
if (res_counter_soft_limit_excess(&memcg->res))
return VISIT;
......@@ -142,7 +142,9 @@ static bool global_reclaim(struct scan_control *sc)
static bool mem_cgroup_should_soft_reclaim(struct scan_control *sc)
return !mem_cgroup_disabled();
struct mem_cgroup *root = sc->target_mem_cgroup;
return !mem_cgroup_disabled() &&
mem_cgroup_soft_reclaim_eligible(root, root) != SKIP_TREE;
static bool global_reclaim(struct scan_control *sc)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment