Skip to content
  • David Howells's avatar
    RCU: Don't try and predeclare inline funcs as it upsets some versions of gcc · 5b1d07ed
    David Howells authored
    
    
    Don't try and predeclare inline funcs like this:
    
    	static inline void wait_migrated_callbacks(void)
    	...
    	static void _rcu_barrier(enum rcu_barrier type)
    	{
    		...
    		wait_migrated_callbacks();
    	}
    	...
    	static inline void wait_migrated_callbacks(void)
    	{
    		wait_event(rcu_migrate_wq, !atomic_read(&rcu_migrate_type_count));
    	}
    
    as it upsets some versions of gcc under some circumstances:
    
    	kernel/rcupdate.c: In function `_rcu_barrier':
    	kernel/rcupdate.c:125: sorry, unimplemented: inlining failed in call to 'wait_migrated_callbacks': function body not available
    	kernel/rcupdate.c:152: sorry, unimplemented: called from here
    
    This can be dealt with by simply putting the static variables (rcu_migrate_*)
    at the top, and moving the implementation of the function up so that it
    replaces its forward declaration.
    
    Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Cc: Dipankar Sarma <dipankar@in.ibm.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    5b1d07ed