• Stephen Hemminger's avatar
    headerdep: perlcritic warning · 1dcd8100
    Stephen Hemminger authored
    Minor perlcritic warning:
    headerdep.pl: "return" statement with explicit "undef" at line 84, column 2.  See page 199 of PBP.  (Severity: 5)
    The rationale according to PBP is that an explicit return of undef
    (contrary to most people's expectations) doesn't
    always evaluate as false. It has to with the fact that perl return value
    depends on context the function is called. If function is used in
    list context, the appropriate return value for false is an empty list;
    whereas in scalar context the return value for false is undefined.
    By just using a "return" both cases are handled.
    In the context of a trivial script this doesn't matter. But one script
    may be cut-paste into later code (most people like me only know 50%
    of perl), that is why perlcritic always complains
    Signed-off-by: default avatarStephen Hemminger <shemminger@vyatta.com>
    Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
headerdep.pl 3.46 KB