Skip to content
  • Guoqing Jiang's avatar
    md: changes for MD_STILL_CLOSED flag · af8d8e6f
    Guoqing Jiang authored
    
    
    When stop clustered raid while it is pending on resync,
    MD_STILL_CLOSED flag could be cleared since udev rule
    is triggered to open the mddev. So obviously array can't
    be stopped soon and returns EBUSY.
    
    	mdadm -Ss          md-raid-arrays.rules
      set MD_STILL_CLOSED          md_open()
    	... ... ...          clear MD_STILL_CLOSED
    	do_md_stop
    
    We make below changes to resolve this issue:
    
    1. rename MD_STILL_CLOSED to MD_CLOSING since it is set
       when stop array and it means we are stopping array.
    2. let md_open returns early if CLOSING is set, so no
       other threads will open array if one thread is trying
       to close it.
    3. no need to clear CLOSING bit in md_open because 1 has
       ensure the bit is cleared, then we also don't need to
       test CLOSING bit in do_md_stop.
    
    Reviewed-by: default avatarNeilBrown <neilb@suse.com>
    Signed-off-by: default avatarGuoqing Jiang <gqjiang@suse.com>
    Signed-off-by: default avatarShaohua Li <shli@fb.com>
    af8d8e6f