Commit 7f71f461 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman

gpio: msic: fix error return code in platform_msic_gpio_probe()

[ Upstream commit ca1f3ae3 ]

platform_get_irq() returns an error code, but the gpio-msic driver
ignores it and always returns -EINVAL. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.
Signed-off-by: 's avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: 's avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: 's avatarSasha Levin <sashal@kernel.org>
parent 20d01c51
......@@ -266,8 +266,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
int i;
if (irq < 0) {
dev_err(dev, "no IRQ line\n");
return -EINVAL;
dev_err(dev, "no IRQ line: %d\n", irq);
return irq;
}
if (!pdata || !pdata->gpio_base) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment