Commit 8e290cec authored by Gavin Li's avatar Gavin Li Committed by Kalle Valo

brcmfmac: fix incorrect event channel deduction

brcmf_sdio_fromevntchan() was being called on the the data frame
rather than the software header, causing some frames to be
mischaracterized as on the event channel rather than the data channel.

This fixes a major performance regression (due to dropped packets). With
this patch the download speed jumped from 1Mbit/s back up to 40MBit/s due
to the sheer amount of packets being incorrectly processed.

Fixes: c56caa9d ("brcmfmac: screening firmware event packet")
Signed-off-by: 's avatarGavin Li <git@thegavinli.com>
Cc: <stable@vger.kernel.org> # 4.7+
Acked-by: 's avatarArend van Spriel <arend.vanspriel@broadcom.com>
[kvalo@codeaurora.org: improve commit logs based on email discussion]
Signed-off-by: 's avatarKalle Valo <kvalo@codeaurora.org>
parent 1ee83789
...@@ -1661,7 +1661,7 @@ static u8 brcmf_sdio_rxglom(struct brcmf_sdio *bus, u8 rxseq) ...@@ -1661,7 +1661,7 @@ static u8 brcmf_sdio_rxglom(struct brcmf_sdio *bus, u8 rxseq)
pfirst->len, pfirst->next, pfirst->len, pfirst->next,
pfirst->prev); pfirst->prev);
skb_unlink(pfirst, &bus->glom); skb_unlink(pfirst, &bus->glom);
if (brcmf_sdio_fromevntchan(pfirst->data)) if (brcmf_sdio_fromevntchan(&dptr[SDPCM_HWHDR_LEN]))
brcmf_rx_event(bus->sdiodev->dev, pfirst); brcmf_rx_event(bus->sdiodev->dev, pfirst);
else else
brcmf_rx_frame(bus->sdiodev->dev, pfirst, brcmf_rx_frame(bus->sdiodev->dev, pfirst,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment