Commit afa648ba authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

drm: gma500: fix logic error

commit 67a3b63a upstream.

gcc-8 points out a condition that almost certainly doesn't
do what the author had in mind:

drivers/gpu/drm/gma500/mdfld_intel_display.c: In function 'mdfldWaitForPipeEnable':
drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]

This changes it to a simple bit mask operation to check
whether the bit is set.

Fixes: 026abc33 ("gma500: initial medfield merge")
Signed-off-by: default avatarArnd Bergmann <>
Signed-off-by: default avatarDaniel Vetter <>
Link: default avatarGreg Kroah-Hartman <>
parent 44cf1d4a
......@@ -99,7 +99,7 @@ void mdfldWaitForPipeEnable(struct drm_device *dev, int pipe)
/* Wait for for the pipe enable to take effect. */
for (count = 0; count < COUNT_MAX; count++) {
temp = REG_READ(map->conf);
if ((temp & PIPEACONF_PIPE_STATE) == 1)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment