Commit c5cc3e03 authored by Markus Hofstaetter's avatar Markus Hofstaetter Committed by Greg Kroah-Hartman

leds: call led_pwm_set() in leds-pwm to enforce default LED_OFF

commit f1670336 upstream.

Some PWMs are disabled by default or the default pin setting
does not match the LED_OFF state (e.g., active-low leds).
Hence, the driver may end up reporting 0 brightness, but
the leds are actually on using full brightness, because
it never enforces its default configuration.
So enforce it by calling led_pwm_set() after successfully
registering the device.

Tested on a Phytec phyFLEX i.MX6Q board based on kernel
Signed-off-by: default avatarMarkus Hofstaetter <>
Tested-by: default avatarMarkus Hofstaetter <>
Signed-off-by: default avatarJacek Anaszewski <>
Signed-off-by: default avatarKrzysztof Kozlowski <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 5403677a
......@@ -132,6 +132,7 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
ret = led_classdev_register(dev, &led_data->cdev);
if (ret == 0) {
led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
} else {
dev_err(dev, "failed to register PWM led for %s: %d\n",
led->name, ret);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment