• Christian Grönke's avatar
    igb: Remove superfluous reset to PHY and page 0 selection · a5ce9639
    Christian Grönke authored
    [ Upstream commit 2a83fba6cae89dd9c0625e68ff8ffff791c67ac0 ]
    
    This patch reverts two previous applied patches to fix an issue
    that appeared when using SGMII based SFP modules. In the current
    state the driver will try to reset the PHY before obtaining the
    phy_addr of the SGMII attached PHY. That leads to an error in
    e1000_write_phy_reg_sgmii_82575. Causing the initialization to
    fail:
    
        igb: Intel(R) Gigabit Ethernet Network Driver - version 5.4.0-k
        igb: Copyright (c) 2007-2014 Intel Corporation.
        igb: probe of ????:??:??.? failed with error -3
    
    The patches being reverted are:
    
        commit 18278533
        Author: Aaron Sierra <asierra@xes-inc.com>
        Date:   Tue Nov 29 10:03:56 2016 -0600
    
            igb: reset the PHY before reading the PHY ID
    
        commit 440aeca4
        Author: Matwey V Kornilov <matwey@sai.msu.ru>
        Date:   Thu Nov 24 13:32:48 2016 +0300
    
             igb: Explicitly select page 0 at initialization
    
    The first reverted patch directly causes the problem mentioned above.
    In case of SGMII the phy_addr is not known at this point and will
    only be obtained by 'igb_get_phy_id_82575' further down in the code.
    The second removed patch selects forces selection of page 0 in the
    PHY. Something that the reset tries to address as well.
    
    As pointed out by Alexander Duzck, the patch below fixes the same
    issue but in the proper location:
    
        commit 4e684f59
        Author: Chris J Arges <christopherarges@gmail.com>
        Date:   Wed Nov 2 09:13:42 2016 -0500
    
            igb: Workaround for igb i210 firmware issue
    
    Reverts: 440aeca4.
    Reverts: 18278533.
    Signed-off-by: default avatarChristian Grönke <c.groenke@infodas.de>
    Reviewed-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
    Tested-by: default avatarAaron Brown <aaron.f.brown@intel.com>
    Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    a5ce9639
Name
Last commit
Last update
..
accessibility Loading commit data...
acpi Loading commit data...
amba Loading commit data...
android Loading commit data...
ata Loading commit data...
atm Loading commit data...
auxdisplay Loading commit data...
base Loading commit data...
bcma Loading commit data...
block Loading commit data...
bluetooth Loading commit data...
bus Loading commit data...
cdrom Loading commit data...
char Loading commit data...
clk Loading commit data...
clocksource Loading commit data...
connector Loading commit data...
cpufreq Loading commit data...
cpuidle Loading commit data...
crypto Loading commit data...
dca Loading commit data...
devfreq Loading commit data...
dio Loading commit data...
dma Loading commit data...
dma-buf Loading commit data...
edac Loading commit data...
eisa Loading commit data...
extcon Loading commit data...
firewire Loading commit data...
firmware Loading commit data...
fmc Loading commit data...
fpga Loading commit data...
gpio Loading commit data...
gpu Loading commit data...
hid Loading commit data...
hsi Loading commit data...
hv Loading commit data...
hwmon Loading commit data...
hwspinlock Loading commit data...
hwtracing Loading commit data...
i2c Loading commit data...
ide Loading commit data...
idle Loading commit data...
iio Loading commit data...
infiniband Loading commit data...
input Loading commit data...
iommu Loading commit data...
ipack Loading commit data...
irqchip Loading commit data...
isdn Loading commit data...
leds Loading commit data...
lguest Loading commit data...
lightnvm Loading commit data...
macintosh Loading commit data...
mailbox Loading commit data...
mcb Loading commit data...
md Loading commit data...
media Loading commit data...
memory Loading commit data...
memstick Loading commit data...
message Loading commit data...
mfd Loading commit data...
misc Loading commit data...
mmc Loading commit data...
mtd Loading commit data...
net Loading commit data...
nfc Loading commit data...
ntb Loading commit data...
nubus Loading commit data...
nvdimm Loading commit data...
nvme Loading commit data...
nvmem Loading commit data...
of Loading commit data...
oprofile Loading commit data...
parisc Loading commit data...
parport Loading commit data...
pci Loading commit data...
pcmcia Loading commit data...
perf Loading commit data...
phy Loading commit data...
pinctrl Loading commit data...
platform Loading commit data...
pnp Loading commit data...
power Loading commit data...
powercap Loading commit data...
pps Loading commit data...
ps3 Loading commit data...
ptp Loading commit data...
pwm Loading commit data...
rapidio Loading commit data...
ras Loading commit data...
regulator Loading commit data...
remoteproc Loading commit data...
reset Loading commit data...
rpmsg Loading commit data...
rtc Loading commit data...
s390 Loading commit data...
sbus Loading commit data...
scsi Loading commit data...
sfi Loading commit data...
sh Loading commit data...
sn Loading commit data...
soc Loading commit data...
spi Loading commit data...
spmi Loading commit data...
ssb Loading commit data...
staging Loading commit data...
target Loading commit data...
tc Loading commit data...
thermal Loading commit data...
thunderbolt Loading commit data...
tty Loading commit data...
uio Loading commit data...
usb Loading commit data...
uwb Loading commit data...
vfio Loading commit data...
vhost Loading commit data...
video Loading commit data...
virt Loading commit data...
virtio Loading commit data...
vlynq Loading commit data...
vme Loading commit data...
w1 Loading commit data...
watchdog Loading commit data...
xen Loading commit data...
zorro Loading commit data...
Kconfig Loading commit data...
Makefile Loading commit data...