Commit 8ad01ce3 authored by Stefan Roese's avatar Stefan Roese Committed by Bin Meng

x86: Remove x86 specific GD flags as they are not referenced at all

This patch removes the x86 architecture specific GD flags
(GD_FLG_COLD_BOOT & GD_FLG_WARM_BOOT), as they are not used. Only
GD_FLG_COLD_BOOT is referenced in coreboot.c but assigned in start16.S.
But the coreboot target does not use start16.S at all and boots directly
from the 32-bit start code.
Signed-off-by: Stefan Roese's avatarStefan Roese <>
Cc: Bin Meng <>
Cc: Simon Glass <>
Cc: Tom Rini <>
Cc: Simon Goldschmidt <>
Reviewed-by: Bin Meng's avatarBin Meng <>
Tested-by: Bin Meng's avatarBin Meng <>
Reviewed-by: default avatarSimon Goldschmidt <>
parent ad79d603
......@@ -73,9 +73,6 @@ static void board_final_cleanup(void)
int last_stage_init(void)
if (gd->flags & GD_FLG_COLD_BOOT)
/* start usb so that usb keyboard can be used as input device */
......@@ -40,9 +40,6 @@ _x86boot_start:
movl %eax, %cr0
/* Tell 32-bit code it is being entered from an in-RAM copy */
movl $GD_FLG_WARM_BOOT, %ebx
* Zero the BIST (Built-In Self Test) value since we don't have it.
* It must be 0 or the previous loader would have reported an error.
......@@ -55,11 +52,7 @@ _x86boot_start:
.align 4
.long 0x12345678
* This is the 32-bit cold-reset entry point, coming from start16.
* Set %ebx to GD_FLG_COLD_BOOT to indicate this.
movl $GD_FLG_COLD_BOOT, %ebx
/* This is the 32-bit cold-reset entry point, coming from start16 */
/* Save BIST */
movl %eax, %ebp
......@@ -23,9 +23,6 @@ start16:
/* Save BIST */
movl %eax, %ecx
/* Set the Cold Boot / Hard Reset flag */
movl $GD_FLG_COLD_BOOT, %ebx
xorl %eax, %eax
movl %eax, %cr3 /* Invalidate TLB */
......@@ -137,10 +137,4 @@ static inline __attribute__((no_instrument_function)) gd_t *get_fs_gd_ptr(void)
* Our private Global Data Flags
#define GD_FLG_COLD_BOOT 0x10000 /* Cold Boot */
#define GD_FLG_WARM_BOOT 0x20000 /* Warm Boot */
#endif /* __ASM_GBL_DATA_H */
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment