Commit 9f8932d0 authored by Heinrich Schuchardt's avatar Heinrich Schuchardt 💬

efi_loader: do not call efi_runtime_detach twice

Commit 7f95104d ("efi_loader: detach runtime in ExitBootServices()")
added a call to efi_runtime_detach() to ExitBootServices() but did not
remove the call in SetVirtualAddressMap().

Remove the superfluous function call.

Correct a comment referring to efi_runtime_detach().

Fixes: 7f95104d ("efi_loader: detach runtime in ExitBootServices()")
Signed-off-by: Heinrich Schuchardt's avatarHeinrich Schuchardt <>
parent 53e1d8fa
......@@ -565,7 +565,10 @@ void efi_runtime_relocate(ulong offset, struct efi_mem_desc *map)
p = (void*)((ulong)rel->offset - base) + gd->relocaddr;
/* The runtime services are updated in efi_runtime_detach() */
* The runtime services table is updated in
* efi_relocate_runtime_table()
if (map && efi_is_runtime_service_pointer(p))
......@@ -724,14 +727,6 @@ static efi_status_t EFIAPI efi_set_virtual_address_map(
* Some runtime services are implemented in a way that we can only offer
* them at boottime. Replace those function pointers.
* TODO: move this call to ExitBootServices().
/* Relocate the runtime. See TODO above */
for (i = 0; i < n; i++) {
struct efi_mem_desc *map;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment