Commit d0bd8761 authored by Heinrich Schuchardt's avatar Heinrich Schuchardt 💬

efi_selftest: fix test_hii_string_get_string()

The check testing the string result of get_string() returned the wrong
result. The result was ignored.

Use efi_st_strcmp_16_8() for the string comparison.
Signed-off-by: Heinrich Schuchardt's avatarHeinrich Schuchardt <>
parent 1646e092
......@@ -783,19 +783,10 @@ static int test_hii_string_get_string(void)
goto out;
#if 1
u16 *c1, *c2;
for (c1 = string, c2 = L"Japanese"; *c1 == *c2; c1++, c2++)
if (!*c1 && !*c2)
result = EFI_ST_SUCCESS;
result = EFI_ST_FAILURE;
/* TODO: %ls */
efi_st_printf("got string is %s (can be wrong)\n", string);
if (efi_st_strcmp_16_8(string, "Japanese")) {
efi_st_error("get_string returned incorrect string\n");
goto out;
result = EFI_ST_SUCCESS;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment