Skip to content
  • Heba Aamer's avatar
    staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet... · 48eaa7f5
    Heba Aamer authored
    
    staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
    
    This patch fixes the following checkpatch.pl warning:
    fix Prefer ether_addr_copy() over memcpy()
    if the Ethernet addresses are __aligned(2)
    
    Pahole showed that the 2 structs are aligned to u16
    
    struct vnt_mic_hdr {
            u8                         id;                   /*     0     1 */
            u8                         tx_priority;          /*     1     1 */
            u8                         mic_addr2[6];         /*     2     6 */
            u8                         ccmp_pn[6];           /*     8     6 */
            __be16                     payload_len;          /*    14     2 */
            __be16                     hlen;                 /*    16     2 */
            __le16                     frame_control;        /*    18     2 */
            u8                         addr1[6];             /*    20     6 */
            u8                         addr2[6];             /*    26     6 */
            u8                         addr3[6];             /*    32     6 */
            __le16                     seq_ctrl;             /*    38     2 */
            u8                         addr4[6];             /*    40     6 */
            u16                        packing;              /*    46     2 */
    
            /* size: 48, cachelines: 1, members: 13 */
            /* last cacheline: 48 bytes */
    };
    
    struct ieee80211_hdr {
            __le16                     frame_control;        /*     0     2 */
            __le16                     duration_id;          /*     2     2 */
            u8                         addr1[6];             /*     4     6 */
            u8                         addr2[6];             /*    10     6 */
            u8                         addr3[6];             /*    16     6 */
            __le16                     seq_ctrl;             /*    22     2 */
            u8                         addr4[6];             /*    24     6 */
    
            /* size: 30, cachelines: 1, members: 7 */
            /* last cacheline: 30 bytes */
    };
    
    Signed-off-by: default avatarHeba Aamer <heba93aamer@gmail.com>
    Reviewed-by: default avatarAya Mahfouz <mahfouz.saif.elyazal@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    48eaa7f5