Skip to content
  • NeilBrown's avatar
    md/bitmap: disable bitmap_resize for file-backed bitmaps. · e8a27f83
    NeilBrown authored
    
    
    bitmap_resize() does not work for file-backed bitmaps.
    The buffer_heads are allocated and initialized when
    the bitmap is read from the file, but resize doesn't
    read from the file, it loads from the internal bitmap.
    When it comes time to write the new bitmap, the bh is
    non-existent and we crash.
    
    The common case when growing an array involves making the array larger,
    and that normally means making the bitmap larger.  Doing
    that inside the kernel is possible, but would need more code.
    It is probably easier to require people who use file-backed
    bitmaps to remove them and re-add after a reshape.
    
    So this patch disables the resizing of arrays which have
    file-backed bitmaps.  This is better than crashing.
    
    Reported-by: default avatarZhilong Liu <zlliu@suse.com>
    Fixes: d60b479d
    
     ("md/bitmap: add bitmap_resize function to allow bitmap resizing.")
    Cc: stable@vger.kernel.org (v3.5+).
    Signed-off-by: default avatarNeilBrown <neilb@suse.com>
    Signed-off-by: default avatarShaohua Li <shli@fb.com>
    e8a27f83