Skip to content
  • linzhang's avatar
    net: llc: add lock_sock in llc_ui_bind to avoid a race condition · 0908cf4d
    linzhang authored
    
    
    There is a race condition in llc_ui_bind if two or more processes/threads
    try to bind a same socket.
    
    If more processes/threads bind a same socket success that will lead to
    two problems, one is this action is not what we expected, another is
    will lead to kernel in unstable status or oops(in my simple test case,
    cause llc2.ko can't unload).
    
    The current code is test SOCK_ZAPPED bit to avoid a process to
    bind a same socket twice but that is can't avoid more processes/threads
    try to bind a same socket at the same time.
    
    So, add lock_sock in llc_ui_bind like others, such as llc_ui_connect.
    
    Signed-off-by: default avatarLin Zhang <xiaolou4617@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    0908cf4d