• Cong Wang's avatar
    llc: hold llc_sap before release_sock() · 543a6011
    Cong Wang authored
    
    [ Upstream commit f7e43672 ]
    
    syzbot reported we still access llc->sap in llc_backlog_rcv()
    after it is freed in llc_sap_remove_socket():
    
    Call Trace:
     __dump_stack lib/dump_stack.c:77 [inline]
     dump_stack+0x1b9/0x294 lib/dump_stack.c:113
     print_address_description+0x6c/0x20b mm/kasan/report.c:256
     kasan_report_error mm/kasan/report.c:354 [inline]
     kasan_report.cold.7+0x242/0x2fe mm/kasan/report.c:412
     __asan_report_load1_noabort+0x14/0x20 mm/kasan/report.c:430
     llc_conn_ac_send_sabme_cmd_p_set_x+0x3a8/0x460 net/llc/llc_c_ac.c:785
     llc_exec_conn_trans_actions net/llc/llc_conn.c:475 [inline]
     llc_conn_service net/llc/llc_conn.c:400 [inline]
     llc_conn_state_process+0x4e1/0x13a0 net/llc/llc_conn.c:75
     llc_backlog_rcv+0x195/0x1e0 net/llc/llc_conn.c:891
     sk_backlog_rcv include/net/sock.h:909 [inline]
     __release_sock+0x12f/0x3a0 net/core/sock.c:2335
     release_sock+0xa4/0x2b0 net/core/sock.c:2850
     llc_ui_release+0xc8/0x220 net/llc/af_llc.c:204
    
    llc->sap is refcount'ed and llc_sap_remove_socket() is paired
    with llc_sap_add_socket(). This can be amended by holding its refcount
    before llc_sap_remove_socket() and releasing it after release_sock().
    
    Reported-by: <syzbot+6e181fc95081c2cf9051@syzkaller.appspotmail.com>
    Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    543a6011
Name
Last commit
Last update
..
Kconfig Loading commit data...
Makefile Loading commit data...
af_llc.c Loading commit data...
llc_c_ac.c Loading commit data...
llc_c_ev.c Loading commit data...
llc_c_st.c Loading commit data...
llc_conn.c Loading commit data...
llc_core.c Loading commit data...
llc_if.c Loading commit data...
llc_input.c Loading commit data...
llc_output.c Loading commit data...
llc_pdu.c Loading commit data...
llc_proc.c Loading commit data...
llc_s_ac.c Loading commit data...
llc_s_ev.c Loading commit data...
llc_s_st.c Loading commit data...
llc_sap.c Loading commit data...
llc_station.c Loading commit data...
sysctl_net_llc.c Loading commit data...