Skip to content
  • Paul Gortmaker's avatar
    Revert "init: make rootdelay=N consistent with rootwait behaviour" · 8ba4caf1
    Paul Gortmaker authored
    This reverts commit 4dfe694f
    
    .
    
    In that, we did:
    
      Here we move the rootdelay code to be right beside the rootwait code, so
      that their behaviour is consistent.
    
    ...which is fine, but in hindsight, perhaps moving the rootwait to be
    beside the rootdelay would have been better.  We also indicated:
    
      It should be noted that in doing so, the actions based on the
      saved_root_name[0] and initrd_load() were previously put on hold by
      rootdelay=N and now currently will not be delayed.  However, I think
      consistent behaviour is more important than matching historical behaviour
      of delaying the above two operations.
    
    But Pavel reported an instance where an ARM target with root on MMC
    was failing to mount root, and Russell diagnosed it to the fact that
    the call to set ROOT_DEV within the saved_root_name[0] processing
    block mentioned above was no longer being delayed.
    
    Rather than moving both wait clauses to the original position of
    rootdelay and risking unearthing other possible corner case breakage
    at this point in time, we simply revert now and we can revisit
    trying the alternate/earlier location in another development cycle.
    
    Cc: Pavel Machek <pavel@denx.de>
    Cc: Russell King <linux@arm.linux.org.uk>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    8ba4caf1