• Johannes Berg's avatar
    rfkill: rewrite · 19d337df
    Johannes Berg authored
    This patch completely rewrites the rfkill core to address
    the following deficiencies:
     * all rfkill drivers need to implement polling where necessary
       rather than having one central implementation
     * updating the rfkill state cannot be done from arbitrary
       contexts, forcing drivers to use schedule_work and requiring
       lots of code
     * rfkill drivers need to keep track of soft/hard blocked
       internally -- the core should do this
     * the rfkill API has many unexpected quirks, for example being
       asymmetric wrt. alloc/free and register/unregister
     * rfkill can call back into a driver from within a function the
       driver called -- this is prone to deadlocks and generally
       should be avoided
     * rfkill-input pointlessly is a separate module
     * drivers need to #ifdef rfkill functions (unless they want to
       depend on or select RFKILL) -- rfkill should provide inlines
       that do nothing if it isn't compiled in
     * the rfkill structure is not opaque -- drivers need to initialise
       it correctly (lots of sanity checking code required) -- instead
       force drivers to pass the right variables to rfkill_alloc()
     * the documentation is hard to read because it always assumes the
       reader is completely clueless and contains way TOO MANY CAPS
     * the rfkill code needlessly uses a lot of locks and atomic
       operations in locked sections
     * fix LED trigger to actually change the LED when the radio state
       changes -- this wasn't done before
    Tested-by: default avatarAlan Jenkins <alan-jenkins@tuffmail.co.uk>
    Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br> [thinkpad]
    Signed-off-by: default avatarJohannes Berg <johannes@sipsolutions.net>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>