Skip to content
  • Rafael J. Wysocki's avatar
    Hibernation: Fix mark_nosave_pages() · a82f7119
    Rafael J. Wysocki authored
    There is a problem in the hibernation code that triggers on some NUMA
    systems on which pfn_valid() returns 'true' for some PFNs that don't
    belong to any zone.  Namely, there is a BUG_ON() in
    memory_bm_find_bit() that triggers for PFNs not belonging to any
    zone and passing the pfn_valid() test.  On the affected systems it
    triggers when we mark PFNs reported by the platform as not saveable,
    because the PFNs in question belong to a region mapped directly using
    iorepam() (i.e. the ACPI data area) and they pass the pfn_valid()
    test.
    
    Modify memory_bm_find_bit() so that it returns an error if given PFN
    doesn't belong to any zone instead of crashing the kernel and ignore
    the result returned by it in mark_nosave_pages(), while marking the
    "nosave" memory regions.
    
    This doesn't affect the hibernation functionality, as we won't touch
    the PFNs in question anyway.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=9966
    
     .
    
    Signed-off-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
    Signed-off-by: default avatarLen Brown <len.brown@intel.com>
    a82f7119