Skip to content
  • Mattijs Korpershoek's avatar
    lib: sparse: allocate FASTBOOT_MAX_BLK_WRITE instead of small number · b1aade87
    Mattijs Korpershoek authored and Tom Rini's avatar Tom Rini committed
    Commit 62649165 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
    fixed cache alignment for systems with a D-CACHE.
    
    However it introduced some performance regressions [1] on system
    flashing huge images, such as Android.
    
    On AM62x SK EVM, we also observe such performance penalty:
    Sending sparse 'super' 1/2 (768793 KB)             OKAY [ 23.954s]
    Writing 'super'                                    OKAY [ 75.926s]
    Sending sparse 'super' 2/2 (629819 KB)             OKAY [ 19.641s]
    Writing 'super'                                    OKAY [ 62.849s]
    Finished. Total time: 182.474s
    
    The reason for this is that we use an arbitrary small buffer
    (info->blksz * 100) for transferring.
    
    Fix it by using a bigger buffer (info->blksz * FASTBOOT_MAX_BLK_WRITE)
    as suggested in the original's patch review [2].
    
    With this patch, performance impact is mitigated:
    Sending sparse 'super' 1/2 (768793 KB)             OKAY [ 23.912s]
    Writing 'super'           ...
    b1aade87